[v20.x] backport V8 changes related to compile cache#56711
Closed
joyeecheung wants to merge 221 commits intonodejs:v20.x-stagingfrom
Closed
[v20.x] backport V8 changes related to compile cache#56711joyeecheung wants to merge 221 commits intonodejs:v20.x-stagingfrom
joyeecheung wants to merge 221 commits intonodejs:v20.x-stagingfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the following bug fixes in V8 that are related to compile cache.
https://chromium-review.googlesource.com/c/v8/v8/+/4998581
https://chromium-review.googlesource.com/c/v8/v8/+/4962094
https://chromium-review.googlesource.com/c/v8/v8/+/5401780
https://chromium-review.googlesource.com/c/v8/v8/+/6140933
The motivation of backporting these is that they would help backporting compile cache to v20.x, which would in turn help backporting require(esm) because the two are a bit intertwined in the module compilation/format detection routine, so there would be more conflicts if we backport
require(esm)without backporting the compile cache.One of them fixes in-isolate compilation cache hit for
comepileFunction()and another fixesimport()when code cache is used, which may be meaningful in themselves for use cases like Jest (e.g. jestjs/jest#15461).Refs: #52697